Refactor Zarr store writing #18
Merged
emmanuelmathot merged 29 commits intomainfrom Aug 13, 2025
Merged
Conversation
- Implemented `reproduce_consolidation_issue.py` to demonstrate the behavior of `zarr.consolidate_metadata()` at different hierarchical levels. - Created `test_consolidation_scenarios.py` to test various scenarios related to consolidation behavior and verify the issue described in the GitHub issue. - Added `test_tom_scenario.py` to replicate the test case provided by TomAugspurger and analyze consolidation results. - Developed `test_xarray_to_zarr_consolidation.py` to investigate how xarray's `to_zarr()` function interacts with consolidated metadata. - Introduced `open_sample.py` for accessing Zarr data from an S3 bucket using xarray and obstore. - Enhanced tests to check for consolidated metadata presence before and after consolidation operations.
…ate group handling in GeoZarr dataset creation
…d clarity; update references in GeoZarr conversion and utility functions.
…mapping attributes and ensuring proper metadata for data variables.
… spatial chunk handling
…ency - Cleaned up whitespace and formatting in geozarr.py to enhance code readability. - Updated the validation logic in utils.py to ensure proper checks for existing band data. - Modified test_cli_e2e.py to improve assertions and formatting for better clarity. - Enhanced test_conversion.py by refining the structure and ensuring consistent formatting. - Removed the unused open_sample.py file to declutter the repository.
- Updated print statements for better formatting and clarity in cli.py, geozarr.py, and other modules. - Enhanced S3 storage options handling in fs_utils.py for better readability. - Improved argument parsing in create_parser function for better organization. - Refactored various functions to maintain consistent formatting and style across the codebase. - Added tests to ensure CLI commands and conversion functionalities work as expected. - Cleaned up whitespace and indentation for better code structure.
…tion job from CI workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance metadata handling and improve performance in GeoZarr dataset creation. Update launch configurations for consistency and remove obsolete test scripts.